Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore build gcloud config in yamllint #3446

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Ignore build gcloud config in yamllint #3446

merged 1 commit into from
Oct 23, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Small cleanup to avoid false warnings on local linting.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@markmandel
Ignore build gcloud config in yamllint
f40524c 
Small cleanup to avoid false warnings on local linting.
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 20, 2023
@google-oss-prow google-oss-prow bot added the lgtm label Oct 20, 2023
@markmandel markmandel enabled auto-merge (squash) October 20, 2023 21:30
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 80c69895-eb1a-42b9-85b0-63763c71d805

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author 

Error: query: failed to query with labels: an error on the server ("Internal Server Error: \"/api/v1/namespaces/agones-system/secrets?labelSelector=name%3Dagones%2Cowner%3Dhelm\": the server could not find the requested resource") has prevented the request from succeeding (get secrets)
make: *** [Makefile:426: install] Error 1

Have not seen that before!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4aa353cf-aea5-4bce-bf7f-07fd9d1ffcaa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3446/head:pr_3446 && git checkout pr_3446
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-f40524c-amd64

@markmandel markmandel merged commit 4cebbf9 into googleforgames:main Oct 23, 2023
3 checks passed
@markmandel markmandel deleted the cleanup/yamllint branch October 23, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@zmerlynn zmerlynn zmerlynn approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@zmerlynn zmerlynn

@gongmax gongmax

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @zmerlynn @gongmax